Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: erc721 consecutive extension #202

Merged
merged 103 commits into from
Aug 12, 2024
Merged

feat: erc721 consecutive extension #202

merged 103 commits into from
Aug 12, 2024

Conversation

qalisander
Copy link
Member

@qalisander qalisander commented Jul 17, 2024 •
edited
Loading

This extension matches the solidity implementation except one thing:

  • to be able to override erc721 methods _owner_of_inner and _update some functions are duplicated from erc721 token standard

Resolves #68

PR Checklist

  • Tests
  • Documentation

bidzyyys
bidzyyys reviewed Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in a second pass. I agree with comments left by @alexfertel that are still to be resolved.

@qalisander qalisander marked this pull request as draft August 6, 2024 12:38
@qalisander qalisander marked this pull request as ready for review August 7, 2024 08:27
alexfertel
alexfertel approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@alexfertel alexfertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment regarding test function names.

contracts/src/token/erc721/mod.rs Outdated Show resolved Hide resolved
bidzyyys
bidzyyys reviewed Aug 8, 2024
View reviewed changes
contracts/src/token/erc721/extensions/consecutive.rs
/// Erc721 contract storage.
Erc721 erc721;
/// Checkpoint library contract for sequential ownership.
Trace160 _sequential_ownership;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO there is some inconsistency in naming, erc721 and than prefixed with _, like _sequential_ownership

bidzyyys
bidzyyys approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @qalisander!
I left some minor comments and nits.

contracts/src/token/erc721/extensions/consecutive.rs Outdated Show resolved Hide resolved
contracts/src/token/erc721/extensions/consecutive.rs Outdated Show resolved Hide resolved
contracts/src/token/erc721/extensions/consecutive.rs Outdated Show resolved Hide resolved
contracts/src/token/erc721/extensions/consecutive.rs Outdated Show resolved Hide resolved
contracts/src/token/erc721/extensions/consecutive.rs Outdated Show resolved Hide resolved
contracts/src/token/erc721/extensions/consecutive.rs Outdated Show resolved Hide resolved
contracts/src/token/erc721/extensions/consecutive.rs Outdated Show resolved Hide resolved
contracts/src/token/erc721/extensions/consecutive.rs Outdated Show resolved Hide resolved
contracts/src/token/erc721/extensions/consecutive.rs Show resolved Hide resolved
contracts/src/token/erc721/mod.rs Show resolved Hide resolved
@qalisander qalisander merged commit a19abc5 into main Aug 12, 2024
21 checks passed
@bidzyyys bidzyyys deleted the erc721-consecutive branch October 15, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggonzalez94 ggonzalez94 ggonzalez94 left review comments

@bidzyyys bidzyyys bidzyyys approved these changes

@alexfertel alexfertel alexfertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERC-721 Consecutive
5 participants
@qalisander @ggonzalez94 @alexfertel @bidzyyys @developeruche